This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Adjust settings so fast refresh works in development #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiWilkin
approved these changes
Mar 15, 2021
After upgrading to CRA 4 and craco hot module reloading was not working. We referenced another project that was using fast refresh and copied in settings to match. We removed the environment variables from the `start` script in `package.json` because they duplicate variable set in docker-compose.yml. Within `docker-compose.yml` we reduced `CHOKIDAR_INTERVAL`, set `working_dir`, and switched to node 12 to match another project using fast refresh. On other projects we have kept the versions of react and react-dom in sync, so we updated the version on `react-dom` in `package.json`.
jwalgran
force-pushed
the
feature/jcw/fast-refresh
branch
from
1e1f4b0
to
37672cf
Compare
|
Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After upgrading to CRA 4 and craco hot module reloading was not working. We referenced another project that was using fast refresh and copied in settings to match.
We removed the environment variables from the
startscript inpackage.jsonbecause they duplicate variable set in docker-compose.yml.Within
docker-compose.ymlwe reducedCHOKIDAR_INTERVAL, setworking_dir, and switched to node 12 to match another project using fast refresh.On other projects we have kept the versions of react and react-dom in sync, so we updated the version on
react-dominpackage.json.Connects #1252
Demo
Testing Instructions
./scripts/updateand./scripts/serverChecklist
fixup!commits have been squashed