This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Download Excel Data #1293
Merged
Download Excel Data #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at this now. |
jwalgran
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Works perfectly. I verified CSV download still works and then downloaded facilities from Turkey as an XLSX, which often have unicode characters in names and addresses. I was able to open and view the XLSX in LibreOffice, Numbers, and Google Sheets and see the unicode characters correctly.
Moves the download button from the two files in which it appears into a single component, in order to more easily update the code to allow .xlsx downloads.
Switch the download button to a dropdown menu, and allow users to choose between XLSX and CSV format.
TaiWilkin
force-pushed
the
tw/download-excel-data
branch
from
4a6d4d4
to
a47df29
Compare
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows users to download the facilities list as an
.xlsxfile, in addition to.csv.Connects #955
Demo
Testing Instructions
vagrant sshand run./scripts/update./scripts/serverChecklist
fixup!commits have been squashed