This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseycesari
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typos, but otherwise good to go.
<strong> | ||
This list must include any additional data points you would | ||
like to display on your customized map, such as facility | ||
type, number or workers etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: or
-> of
.
website for packages and pricing options. | ||
</Typography> | ||
<Typography paragraph> | ||
Once you have activated, your OAR Embedded Map Settings will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Once you have activated
-> Once you have activated it
TaiWilkin
force-pushed
the
tw/full-width-iframe
branch
from
May 26, 2021 19:44
97ec214
to
90a39f3
Compare
Updates the text on the embedded map settings page to match the latest copy provided by the OAR team.
When a contributor initially loads their embedded map settings page, no embed fields have been created. However, previously, inactive fields were being displayed as activated. They now display the actual data state.
If a user doesn't have access to the embedded map feature, they will see an information message on the settings page instead of the map configuration controls.
TaiWilkin
force-pushed
the
tw/embedded-map-cleanup
branch
from
May 26, 2021 20:10
e5adefd
to
0284192
Compare
Thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Several elements of the embedded map settings page required minor updates.
Connects #1351
Demo
Unauthorized:
Authorized:
Notes
Text copy
Testing Instructions
./scripts/server
and login with a user with a null embed_level.Checklist
fixup!
commits have been squashed