Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Embedded map settings changes #1353

Merged
merged 3 commits into from May 26, 2021
Merged

Embedded map settings changes #1353

merged 3 commits into from May 26, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented May 25, 2021

Overview

Several elements of the embedded map settings page required minor updates.

  • Updated the text copy to reflect the updated content in the wireframes.
  • Set the individual contributor fields to be turned off by default, to reflect the actual initial state of the data (the EmbedFields aren't created until a change is made on the settings page).
  • When a user with an embed_level of null (ie no embedded map access) attempts to access the settings page, shows a message stating that they aren't authorized to access the page and should reach out to OAR staff for access.

Connects #1351

Demo

Unauthorized:
Screen Shot 2021-05-25 at 4 53 14 PM

Authorized:
Screen Shot 2021-05-25 at 4 55 02 PM

Notes

Text copy

Testing Instructions

  • Run ./scripts/server and login with a user with a null embed_level.
  • Navigate to settings.
    • On the embed tab, you should see the message from the text copy.
  • Change the user permissions to the highest embed level and refresh the settings.
    • You should see the usual page.
    • The text should be updated.
    • The contributor fields should not be selected by default.
  • Select the contributor fields.
    • The fields should be selectable and maintain their selection on refresh as before.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, but otherwise good to go.

<strong>
This list must include any additional data points you would
like to display on your customized map, such as facility
type, number or workers etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: or -> of.

website for packages and pricing options.
</Typography>
<Typography paragraph>
Once you have activated, your OAR Embedded Map Settings will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Once you have activated -> Once you have activated it

@caseycesari caseycesari assigned TaiWilkin and unassigned caseycesari May 26, 2021
Base automatically changed from tw/full-width-iframe to develop May 26, 2021 19:56
Updates the text on the embedded map settings page to match the latest
copy provided by the OAR team.
When a contributor initially loads their embedded map settings page,
no embed fields have been created. However, previously, inactive fields
were being displayed as activated. They now display the actual data
state.
If a user doesn't have access to the embedded map feature, they will
see an information message on the settings page instead of the map
configuration controls.
@TaiWilkin TaiWilkin merged commit 10a0279 into develop May 26, 2021
@TaiWilkin TaiWilkin deleted the tw/embedded-map-cleanup branch May 26, 2021 20:28
@TaiWilkin
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants