Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Use contributor ID rather than user ID when building embed code #1380

Merged
merged 1 commit into from Jun 2, 2021

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Jun 2, 2021

Overview

This should have always been contributor_id but was masked by the fact that user IDs and contributor IDs match in development.

Connects #1379

Demo

2021-06-02 16 43 02

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@jwalgran jwalgran requested a review from TaiWilkin June 2, 2021 23:46
This should have always been `contributor_id` but was masked by the fact that
user IDs and contributor IDs match in development.
@jwalgran jwalgran force-pushed the bugfix/jcw/embed-use-contrib-id branch from ecc4e4b to 739e03b Compare June 2, 2021 23:47
@jwalgran jwalgran merged commit 784c5e2 into release/42 Jun 2, 2021
@jwalgran jwalgran deleted the bugfix/jcw/embed-use-contrib-id branch June 2, 2021 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant