Conditionally change split operation to revert

[jwalgran]

Overview

Conditionally change the split operation on the dashboard to revert in cases when the list item was previously used to create a new facility.

Connects https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/26

Demo

Notes

In production we encountered a situation where a list item was used to create a facility but then through some sequence of moderation activities was matched to a different facility. Attempts to use split function in the dashboard failed because attempting to create a new facility from the list item violated the uniqueness constraint on Facility.created_from.

To work around this problem we now include facility_created_by_item in the data used to populate the dashboard split tool and conditionally offer a "revert" option in place of split and mirror that change in the API view to connect the match to the originally created facility rather than attempting to make a new facility record.## Testing Instructions

Testing

These instructions assume that you have run ./scripts/resetdb

• Log in as c8@example.com, browse http://localhost:6543/lists/8, and confirm the pending matches.
  • Copy the OAR ID for "Nantong Jackbeanie Headwear..."
• Log in as c1@example.com and browse http://localhost:6543/dashboard/adjustfacilitymatches.
• Search for the "Nantong Jackbeanie Headwear..." OAR ID and save the match ID in the right hand column for later. Verify that an action button is labeled "SPLIT"
• Run ./scripts/manage shell_plus and set up the test condition

m = FacilityMatch.objects.get(id={{the match ID}})
f = Facility()
f.country_code = m.facility_list_item.country_code
f.name = m.facility_list_item.name
f.address = m.facility_list_item.address
f.created_from = m.facility_list_item
f.location = m.facility_list_item.geocoded_point
f.save()
f.id

• Note the OAR id printed after the last command and save it for later
• On http://localhost:6543/dashboard/adjustfacilitymatches search for the OAR ID again and verify that the "SPLIT" button is now labeled "REVERT"
• Click "REVERT" and verify that the confirmation modal has a title that includes the OAR ID. Verify that it is the same OAR ID as the facility created through shell_plus.
• Confirm the revert and verify that it completes successfully.

Checklist

• fixup! commits have been squashed
• CI passes after rebase
• CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

[TaiWilkin]

This is working well!

[jwalgran]

Thanks for the review.