Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Conditionally hide remove button #1417

Merged
merged 1 commit into from Jul 12, 2021
Merged

Conditionally hide remove button #1417

merged 1 commit into from Jul 12, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Jul 8, 2021

Overview

Because list items with errors never had matches/facilities created
for them, the remove button in the list dashboard will have no effect.
Hides the remove button for items in an error state.

Connects #1414

Demo

Screen Shot 2021-07-08 at 1 50 50 PM

Testing Instructions

  • Run ./scripts/server login as a contributor. Set several items in a list belonging to that contributor to an error state.
  • View the list with error items. List items with an error status should not have 'remove' buttons.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed 👍

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Jul 9, 2021
Because list items with errors never had matches/facilities created
for them, the remove button in the list dashboard will have no effect.
Hides the remove button for items in an error state.
@TaiWilkin
Copy link
Contributor Author

Thanks for reviewing!

@TaiWilkin TaiWilkin merged commit 6a14fbc into develop Jul 12, 2021
@TaiWilkin TaiWilkin deleted the tw/hide-remove-button branch July 12, 2021 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants