This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Align logout button #1420
Merged
Align logout button #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button for the navigation dropdown for logged-in users was out of line with the links, but is now aligned. Logout, unlike the other items in the navigation, is a button instead of an anchor, because it doesn't navigate the user but rather performs an action in response to a click. This requires it to have different styles, which need to be set using higher specifity CSS classes in order to override the '!important' tags on other CSS classes for nav dropdowns.
TaiWilkin
force-pushed
the
tw/style-logout
branch
from
700c9b2
to
1ed6d0d
Compare
|
Thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The button for the navigation dropdown for logged-in users was out of
line with the links, but is now aligned. Logout, unlike the other items
in the navigation, is a button instead of an anchor, because it doesn't
navigate the user but rather performs an action in response to a click.
This requires it to have different styles, which need to be set using
higher specifity CSS classes in order to override the '!important' tags
on other CSS classes for nav dropdowns.
Connects #1411
Demo
Testing Instructions
./scripts/server, login as any user, and click the user name in the upper right-hand corner to view the log out button. Confirm it is aligned properly at various screen sizes.Checklist
fixup!commits have been squashed