Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix mobile header #1454

Merged
merged 1 commit into from Aug 17, 2021
Merged

Fix mobile header #1454

merged 1 commit into from Aug 17, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Aug 16, 2021

Overview

The updated logo was pushing some buttons out of alignment on mobile.
A media query now adjusts the logo size as needed.

Connects #1453

Demo

Before
Screen Shot 2021-08-16 at 10 09 20 AM

After
Screen Shot 2021-08-16 at 10 16 49 AM
Screen Shot 2021-08-16 at 10 17 00 AM

Testing Instructions

  • Run ./scripts/server
  • View the app at various screen sizes, particularly mobile, and confirm the navigation buttons are aligned.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Thanks for the quick fix.

Screen Shot 2021-08-16 at 10 54 23 AM

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Aug 16, 2021
The updated logo was pushing some buttons out of alignment on mobile.
A media query now adjusts the logo size as needed.
@TaiWilkin
Copy link
Contributor Author

Thanks for reviewing!

@TaiWilkin TaiWilkin merged commit 6778166 into develop Aug 17, 2021
@TaiWilkin TaiWilkin deleted the tw/fix-mobile-header branch August 17, 2021 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants