Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix 'More' Links #1505

Merged
merged 1 commit into from Oct 28, 2021
Merged

Fix 'More' Links #1505

merged 1 commit into from Oct 28, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Oct 27, 2021

Overview

Fixes the links in the 'more' menu, which were incorrectly stored in the
links configuration object, causing 'undefined' routes to be created.

Updates the development info site links to lead to the production info site.

Demo

Screen Shot 2021-10-27 at 3 26 55 PM

Screen Shot 2021-10-27 at 3 27 06 PM

Testing Instructions

  • Run ./scripts/server
  • In Mobile view, test each link in the 'more' navigation.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that these links now work. I am going to merge this so I can git out a quick, small release.

Fix the links in the 'more' menu, which were incorrectly stored in the
links configuration object, causing 'undefined' routes to be created.
@jwalgran jwalgran merged commit 0bd6da5 into develop Oct 28, 2021
@jwalgran jwalgran deleted the tw/fix-more-links branch October 28, 2021 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants