Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add extended profile feature flag #1542

Merged
merged 1 commit into from Dec 2, 2021
Merged

Conversation

TaiWilkin
Copy link
Contributor

Overview

Extended profiles is a long-developing feature which which involve
large changes to the UI. In order to enable ongoing maintenance releases
during development of the new feature, we have added a feature flag to
allow us to hide the new components until we are ready to release them.

Connects #1538

Demo

Screen Shot 2021-11-30 at 12 38 29 PM

Testing Instructions

  • Run ./scripts/manage migrate.
  • Run ./scripts/server and confirm the new switch is present in the Django admin.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. One suggested fixup.

from django.db import migrations


def create_embedded_map_switch(apps, schema_editor):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion I would suggest renaming this function create_extended_profile_switch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Dec 1, 2021
Extended profiles is a long-developing feature which which involve
large changes to the UI. In order to enable ongoing maintenance releases
during development of the new feature, we have added a feature flag to
allow us to hide the new components until we are ready to release them.
@TaiWilkin
Copy link
Contributor Author

Thank you for reviewing!

@TaiWilkin TaiWilkin merged commit 9801367 into develop Dec 2, 2021
@TaiWilkin TaiWilkin deleted the tw/add-extended-fields-flag branch December 2, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants