This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When geocoding a facility, if the country code returned by Google Maps
is different from the country code provided by the user, we throw a
ValueError.
We’re testing this code with an address that previously was getting
mapped by Google Maps to China, and testing that we threw an error
because the user had entered it as India. Google is now returning that
address as being in India, which means that a value error was
(correctly, but breaking the test) not raised.
The test now mocks the API response so that we are testing only our
own code, and not third-party responses.
Connects #1545
Demo
Broken test:
Passing tests:
Notes
Only one of the three geocoding tests were breaking, but I switched to the mock for all three.
Testing Instructions
Checklist
fixup!
commits have been squashed