Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add support for facility_type_processing_type meta extended field #1671

Merged
merged 3 commits into from Feb 24, 2022

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Feb 23, 2022

Overview

In an attempt to avoid confusion the data submission process we will be putting a single facility_type_processing_type column in our upload templates rather than separate facility_type and processing_type columns. Though we are unifying the fields in the template we still want to create separate extended fields for each field type. Supporting this is a simple change because our processing was designed to handle either value type in either field.

We also add str to the ExtendedField model in an attempt to make the list view in the Django admin more helpful.

Connects #1655

Demo

Screen Shot 2022-02-23 at 11 14 35 AM

Screen Shot 2022-02-23 at 11 15 39 AM

Screen Shot 2022-02-23 at 11 04 11 AM

Testing Instructions

{
    "country": "US",
    "name": "API Meta Field Testing",
    "address": "200 Main St Philadelphia PA",
    "number_of_workers": 123,
    "parent_company": "Yet another parenct co",
    "facility_type_processing_type": "cut|warehousing",
	"product_type": ["pants", "suits"]
}

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

In an attempt to avoid confusion the data submission process we will be putting
a single `facility_type_processing_type` column in our upload templates rather
than separate `facility_type` and `processing_type` columns. Though we are
unifying the fields in the template we still want to create separate extended
fields for each field type. Supporting this is a simple change because our
processing was designed to handle either value type in either field.
An attempt to  make the list view in the Django admin more helpful.
@jwalgran jwalgran requested review from TaiWilkin and emilyhu0106 and removed request for TaiWilkin February 23, 2022 18:29
@jwalgran jwalgran marked this pull request as ready for review February 23, 2022 18:30
@jwalgran
Copy link
Contributor Author

Sorry for the extra notification, @TaiWilkin. I moved the assignment over to Emily to balance the review load.

Copy link
Contributor

@emilyhu0106 emilyhu0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! A very nice and sleek implementation

@jwalgran
Copy link
Contributor Author

Thanks for the review.

@jwalgran jwalgran merged commit 0eca74f into develop Feb 24, 2022
@jwalgran jwalgran deleted the feature/jcw/facility_type_processing_type_field branch February 24, 2022 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants