Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix custom text handling when not in embed mode #1673

Merged
merged 1 commit into from Feb 24, 2022

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Feb 23, 2022

Overview

When not in embed mode just searching for free text was raising an exception because contributors was None in filter_by_query_params.

Connects #1652
Connects #1672

Testing Instructions

  • Check out develop
  • Search for test and verify that an exception prevents the search from working
  • Check out this branch, run the same search, and verify that it works.
  • Verify that text search in embed mode still works

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! This is working as expected now

@TaiWilkin TaiWilkin assigned jwalgran and unassigned TaiWilkin Feb 24, 2022
When not in embed mode just searching for free text was raising an exception
because `contributors` was None in `filter_by_query_params`.
@jwalgran jwalgran force-pushed the bugfix/jcw/fix-free-text-filter-handling branch from 8889d31 to 7e5fe16 Compare February 24, 2022 14:37
@jwalgran
Copy link
Contributor Author

Thanks for the review.

@jwalgran jwalgran merged commit ec58f86 into develop Feb 24, 2022
@jwalgran jwalgran deleted the bugfix/jcw/fix-free-text-filter-handling branch February 24, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants