Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Allow submitting non-taxonomy facility type and processing type #1705

Merged
merged 1 commit into from Mar 14, 2022

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Mar 10, 2022

Overview

We previously returned a validation error to contributors submitting facility types and processing types that did not match the taxonomy. When we began testing with contributors the poor user experience and friction this added to the process made us decide to accept and display non-matching values.

Connects #1703

Demo

Screen Shot 2022-03-10 at 3 01 23 PM

Testing Instructions

{
    "country": "US",
    "name": "API Meta Field Testing",
    "address": "200 Main St Philadelphia PA",
    "number_of_workers": 123,
    "parent_company": "adidas",
    "facility_type_processing_type": "banana|sewing",
	"product_type": ["pants", "suits"]
}
  • Browse the new facility and verify that the raw value "banana" appears in both facility type and processing type in addition to the matched taxonomy values for sewing.
  • Download a CSV containing the new facility and verify that "banana" appears in both raw and matched columns for both facility type and processing type.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@jwalgran jwalgran requested a review from TaiWilkin March 11, 2022 20:46
@jwalgran jwalgran marked this pull request as ready for review March 11, 2022 20:46
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for updating the tests.
It feels a bit strange to have unmatched values in the facility details alongside matched values. It would be good to have some kind of visual signifier of matched vs unmatched values in the UI. I think that's a design enhancement for the future and not in scope for this task, however.

@TaiWilkin TaiWilkin assigned jwalgran and unassigned TaiWilkin Mar 14, 2022
We previously returned a validation error to contributors submitting facility types and processing
types that did not match the taxonomy. When we began testing with contributors
the poor user experience and friction this added to the process made us decide
to accept and display non-matching values.
@jwalgran jwalgran force-pushed the feature/jcw/raw-facility-processing-types branch from 5bab6df to 8719433 Compare March 14, 2022 14:30
@jwalgran
Copy link
Contributor Author

Thanks for the review.

I added a reminder to our cumulative notes document to follow up on the design issue.

@jwalgran jwalgran merged commit e731760 into develop Mar 14, 2022
@jwalgran jwalgran deleted the feature/jcw/raw-facility-processing-types branch March 14, 2022 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants