Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Remove native language name from filter sidebar #1722

Merged
merged 1 commit into from Mar 18, 2022

Conversation

emilyhu0106
Copy link
Contributor

@emilyhu0106 emilyhu0106 commented Mar 17, 2022

Overview

Remove the native language name free text field from the filter sidebar while keeping the searching ability upon OAR request

Connects #1717

Demo

image

Testing Instructions

  • Checkout this branch and run server
  • Contribute ExtendedFieldsTestList.csv and fully process it
  • Expand the filter sidebar to show extended fields
    • Make sure "Native Language Name" is not there
    • All other extended field searches work as intended
    • Open http://localhost:6543/facilities?native_language_name=工业 and BAOJI HAWK IND. & TRADE CO. LTD should be found.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@emilyhu0106 emilyhu0106 force-pushed the eh/remove-native-language-field branch from 8d452a3 to 7a3dba9 Compare March 17, 2022 20:53
@jwalgran jwalgran self-requested a review March 17, 2022 22:19
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this until after release 61 is complete.

I had time while waiting for a file upload test on staging and I wanted to expedite this change so it was ready to be released Friday morning. Works as described. Thanks.

@jwalgran jwalgran assigned emilyhu0106 and unassigned TaiWilkin Mar 17, 2022
@jwalgran
Copy link
Contributor

To make sure we are ready for a morning release I am going to fix the changelog conflict and merge this.

Remove the native language name free text field from the filter sidebar
while keeping the searching ability
@jwalgran jwalgran force-pushed the eh/remove-native-language-field branch from 7a3dba9 to a5edce1 Compare March 18, 2022 02:56
@jwalgran jwalgran merged commit 7e06f60 into develop Mar 18, 2022
@jwalgran jwalgran deleted the eh/remove-native-language-field branch March 18, 2022 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants