This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Delay loading search field dropdown data #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also rename the style variable to be consistent with the component file name.
FilterSidebarExtendedSearch was originally extracted from the FilterSidebarSearchTab.
The original hook generated a lint warning for the missing dependencies. Using a single hook resulted in repeat fetches so we split out a separate hook for each distinct fetch.
jwalgran
force-pushed
the
tw/delay-loading-dropdown-data
branch
from
de73db2
to
c45b9ab
Compare
|
I rebased this on develop and force pushed along with some cleanup. |
jwalgran
changed the title
|
We want to make other adjustments to fields in this new sub-component so since I effectively did a review of @TaiWilkin 's initial work I am going to approve and merge this. If there are additional clean ups or changes we would like to do they can be made in a follow up PR. |
jwalgran
approved these changes
Mar 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As part of our redesign of the sidebar to support extended fields we researched search behavior and hid list frequently used search fields. If the search fields are never shown, their dropdown list option do not need to be fetched.
Connects #1729
Demo
Notes
When refreshing the page after selection both a facility type and a processing type, the facility type options do not populate. This is not a regression and is a non-ideal behavior in the current implementation of filtering options based on the connection between facility type and processing type.
Testing Instructions
Checklist
fixup!commits have been squashed