This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Reduce pageSize when downloading to 10 #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At a pageSize of 50 with `detail=true` we are seeing response times near 30s, sometimes timing out. In some brief testing reducing the pageSize to 10 results in requests that take 3 to 6 seconds. Setting a pageSize of 20 doubles the response time but interestingly setting a pageSize of 5 doe _not_ reduce the request time. There appears to be a performance floor.
jwalgran
force-pushed
the
feature/jcw/download-10-at-a-time
branch
from
6f637c6
to
35b0a21
Compare
|
@TaiWilkin reviewed this with me on a screenshare so I will merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At a pageSize of 50 with
detail=truewe are seeing response times near 30s, sometimes timing out.In some brief testing reducing the pageSize to 10 results in requests that take 3 to 6 seconds. Setting a pageSize of 20 doubles the response time but interestingly setting a pageSize of 5 doe not reduce the request time. There appears to be a performance floor.
Demo
The effects of reducing page size in production
Download testing in development
Testing Instructions
Checklist
fixup!commits have been squashed