This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Handle None and string values in Excel percent column #1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change attempts to prevent exceptions when there are non-numeric values in an Excel column that mostly contains numbers formatted as percentages.
In addition we fix the handling of empty cells so that a None value is not
transformed into the string
"None"
.Connects https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/85
Testing Instructions
develop
./scripts/resetdb
Verify that an exception is raised
bugfix/jcw/handle-none-and-string-in-percent-col
./tools/batch_process {id}
to process the list. Verify that there are 2 expected parse failures.percent_female_workers
field and set the embed sizeKH EXPORTS
has a product type but non of the other examples here has a product type of "None"KH EXPORTS INDIA PRIVATE LTD
shows60%
for percent_female_workersSAGE CREATIONS
showsfifteen percent
for percent_female_workersGAURAV
does not have percent_female_workers valueCENTURY OVERSEAS
has a parse error due to missing addressJIVA DESIGNS
does not have a number of workers value but does have18%
for percent_female_workersChecklist
fixup!
commits have been squashed