Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix geocoding error message to include status code #1853

Merged
merged 2 commits into from May 20, 2022

Conversation

maurizi
Copy link
Contributor

@maurizi maurizi commented May 20, 2022

Overview

I was unable to determine the cause of some of geocoding errors being logged here - including the status code should help when this error occurs in the future (and it seems like it was always the intent to include the status code here).

Connects #1788

Testing Instructions

  • I'm not actually sure how to trigger this error?

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

I was unable to determine the cause of some of geocoding errors being
logged here - including the status code should help when this error occurs
in the future
@maurizi maurizi requested a review from TaiWilkin May 20, 2022 11:43
@maurizi maurizi changed the title Fix geocoding error logging to include status code Fix geocoding error message to include status code May 20, 2022
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the code manually to add r.status_code = 404 and then contributed and processed a list. That worked to return the expected error status:
Screen Shot 2022-05-20 at 10 33 56 AM

@TaiWilkin TaiWilkin assigned maurizi and unassigned TaiWilkin May 20, 2022
@maurizi maurizi merged commit aa8e1b9 into develop May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants