Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix processing_type_facility_type_unmatched #1874

Merged
merged 1 commit into from Jun 1, 2022

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented May 31, 2022

Overview

The warning we set up in the processing_type_facility_type_unmatched
report to let us know about certain invalid values
in the system was triggering all the time, and not just when it should
be, due to an indentation issue.

Connects https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/1576/?item_page=0&#similar-items

Testing Instructions

  • On develop, add a debugger or a print statement at the Rollbar error in processing_type_facility_type_unmatched() and ensure you have at least one unmatched processing_type value. Ensure the unmatched value has been added to the system properly.
  • Open the processing_type_facility_type_unmatched report and see that the error is triggered incorrectly.
  • Repeat the above steps on this branch and see that the error is not triggered.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
  • This PR is targeted at the correct branch (develop vs. ogr/develop)
  • If this PR applies to both OAR and OGR a companion PR has been created

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the error and the fix, and had forgotten that Python for statements could have an else.

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran May 31, 2022
The warning we set up to let us know about certain invalid values
in the system was triggering all the time, and not just when it should
be, due to an indentation issue.
@TaiWilkin
Copy link
Contributor Author

Thank you for reviewing!
I had almost forgotten the new OGR workflow, but I've added a PR for the OGR branch. I'll hold off on merging this until that is reviewed, per the order of operations in the Readme.

@TaiWilkin TaiWilkin merged commit 20f7a6d into develop Jun 1, 2022
@TaiWilkin TaiWilkin deleted the tw/fix-processing-errors branch June 1, 2022 15:37
@obrienad obrienad added bug Something isn't working task 47 Q2 2022 bugs, support, maintenance labels Jun 7, 2022
@obrienad obrienad added this to the Q2 2022 milestone Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working task 47 Q2 2022 bugs, support, maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants