This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix processing_type_facility_type_unmatched #1874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The warning we set up in the
processing_type_facility_type_unmatched
report to let us know about certain invalid values
in the system was triggering all the time, and not just when it should
be, due to an indentation issue.
Connects https://rollbar.com/OpenApparelRegistry/OpenApparelRegistry/items/1576/?item_page=0&#similar-items
Testing Instructions
develop
, add a debugger or a print statement at the Rollbar error inprocessing_type_facility_type_unmatched()
and ensure you have at least one unmatched processing_type value. Ensure the unmatched value has been added to the system properly.Checklist
fixup!
commits have been squasheddevelop
vs.ogr/develop
)