Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix delete facility #2019

Merged
merged 2 commits into from Aug 8, 2022
Merged

Fix delete facility #2019

merged 2 commits into from Aug 8, 2022

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Aug 3, 2022

Overview

Allows facilities to be deleted when their created_from
FacilityListItem has multiple associated FacilityMatches.

Connects #1992

Testing Instructions

On develop:

  • Run ./scripts/manage shell_plus.
f = Facility.objects.first()
FacilityMatch.objects.create(status='PENDING', facility=f, facility_list_item=f.created_from, confidence=0.7, results='')
f.id

On this branch:

  • Attempt to delete the same facility on this branch. It should succeed.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
  • This PR is targeted at the correct branch (develop vs. ogr/develop)
  • If this PR applies to both OAR and OGR a companion PR has been created

Allows facilities to be deleted when their created_from
FacilityListItem has multiple associated FacilityMatches.
@TaiWilkin TaiWilkin requested a review from maurizi August 3, 2022 20:18
@TaiWilkin TaiWilkin mentioned this pull request Aug 3, 2022
5 tasks
@TaiWilkin
Copy link
Contributor Author

Thanks for reviewing!

@TaiWilkin TaiWilkin merged commit 265d777 into develop Aug 8, 2022
@TaiWilkin TaiWilkin deleted the tw/fix-delete-facility branch August 8, 2022 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants