fixes map sizing issues and table pagination #392
Conversation
Heads up that there are some linter errors preventing CI from building this branch:
|
Sorry about that, I always forget this project has a linter. |
</Table> | ||
</div> | ||
</Paper> | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this empty tag intentional/required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldnt be required. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fixes look good. Thanks.
This has a slightly tricky merge conflict with #378 where we added a status line.
My idea for reconciling this is to move the status line up out of the FacilityListItemTable
component into the FacilityListItem
component
I changed the status style to help draw attention
fontSize: '1rem',
fontWeight: 500,
padding: '0.5rem',
3c0385f
to
8acf3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these fixes. Looking good.
Overview
Demo
Testing Instructions