Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Remove (beta) from page title #418

Merged
merged 1 commit into from Mar 28, 2019
Merged

Remove (beta) from page title #418

merged 1 commit into from Mar 28, 2019

Conversation

kellyi
Copy link
Contributor

@kellyi kellyi commented Mar 28, 2019 •
edited

Overview

Remove (beta) from page title.

Connects #415

Demo

Screen Shot 2019-03-28 at 10 55 51 AM

Testing Instructions

  • ./scripts/server and verify that you don't see beta in the page title when you visit 6543
  • ./scripts/cibuild and visit 8081 to verify you also don't see it there

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@kellyi kellyi requested a review from jwalgran March 28, 2019 14:56
@kellyi kellyi force-pushed the ki/remove-beta-from-page-title branch from 3f00657 to 9e967ea Compare March 28, 2019 14:58
jwalgran
jwalgran approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't see any other references to "beta" in the code.

@jwalgran jwalgran assigned kellyi and unassigned jwalgran Mar 28, 2019
@kellyi kellyi merged commit 2a219c0 into develop Mar 28, 2019
@kellyi kellyi deleted the ki/remove-beta-from-page-title branch March 28, 2019 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwalgran jwalgran jwalgran approved these changes

Assignees

@kellyi kellyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kellyi @jwalgran @hectcastro