This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Handle CSV files with UTF-8 BOM #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalgran
force-pushed
the
jcw/handle-utf-bom
branch
from
b652dbb
to
66a6bc8
Compare
Some applications, when saving files with a UTF-8 encoding, will prepend a byte order mark (BOM) at the beginning of the file. By using the `utf-8-sig` encoding when reading files we will ignore the BOM if it is present.
jwalgran
force-pushed
the
jcw/handle-utf-bom
branch
from
66a6bc8
to
95c6a5e
Compare
kellyi
approved these changes
Apr 26, 2019
|
Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some applications, when saving files with a UTF-8 encoding, will prepend a byte order mark (BOM) at the beginning of the file. By using the
utf-8-sigencoding when reading files we will ignore the BOM if it is present.Connects #473
Testing Instructions
Checklist
fixup!commits have been squashed