This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fetch client country code and write to app state #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalgran
force-pushed
the
jcw/fetch-client-info
branch
from
e237a6b
to
5fc63ce
Compare
kellyi
reviewed
May 28, 2019
| [completeFetchClientInfo]: (state, payload) => update(state, { | ||
| fetched: { $set: true }, | ||
| countryCode: { $set: payload.country.code } | ||
| }), |
There was a problem hiding this comment.
Would there ever be a need to clear this during the running of the app? It seems like the answer is no but I thought I'd check.
There was a problem hiding this comment.
I don't think we would ever need to clear the fetched client info.
We need to detect if someone is browsing the app from China so that we can change the way in which we load our map components. To facilitate this we make a request to the free userinfo.io service when the `App` component loads and save the returned country to the app state.
jwalgran
force-pushed
the
jcw/fetch-client-info
branch
from
5fc63ce
to
ff0d237
Compare
|
Thanks for the review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We need to detect if someone is browsing the app from China so that we can
change the way in which we load our map components. To facilitate this we make a
request to the free userinfo.io service when the
Appcomponent loads and savethe returned country to the app state.
Connects #538
Demo
The userinfo.io service returning the correct country with the China VPN connection.
Writing country to app state
Setting fetched flag on failure
Testing Instructions
clientInfo.countryCodeis set in the app state.Checklist
fixup!commits have been squashed