Show a list of facilities successfully claimed by the current contributor

[jwalgran]

Overview

Change the "My Facilities" link in the navbar to link to a new page showing a list of all approved facility claims for the currently logged in contributor.

Connects #543

Demo

My Facilities

Empty List

Claim A Facility Disabled

Notes

The wireframes include showing the status of a claim and removing the claim but these are out of scope of #543 which specifies showing only approved claims.

Testing Instructions

This assumes that the fixture data is loaded and processed

• Disable claim a facility with ./scripts/manage waffle_switch claim_a_facility off. Restart `./scripts.server.
• Log in as c2@example.com and verify that "My Facilities" does not appear in the navbar dropdown.
• Enable claim a facility with ./scripts/manage waffle_switch claim_a_facility on. Restart `./scripts.server.
• Log in as c2@example.com, search for a facility, and submit a claim.
• Select "My Facilities" from the navbar dropdown and verify that a "no approved claims" message is shown.
• In a separate browser log in as c1@example.com and browse http://localhost:6543/dashboard/claims. Approve the facility claim.
• Back in the original browser select "My Facilities" from the navbar dropdown and verify that the approved facility now appears and that clicking on it navigates to a placeholder details page.

Checklist

• fixup! commits have been squashed
• CI passes after rebase
• CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

[kellyi]

I made #586 for the wire-frame-related updates.

[kellyi]

I tested this out and it's working almost perfectly! There are two small UI things that may not be blocking on merging, but which I did want to surface in case we would like to address them here or subsequently:

First: in Firefox the "no claimed facilities" message doesn't place the button beneath the message. I think this can be fixed just by putting the two elements in a common container, then giving it display: flex and flex-direction: column:

Second, also in Firefox: when I click a row to go to a facility details page and then click the back button to return to the list page, for a split second I can see the "no claimed facilities" message before searching commences and it changes to the CircularProgress spinner. The back button seemed to be the only condition in which I could create the split-second quirk. It's not a show-stopper, though, so we could live with it if it's not easy to remedy.

[kellyi]

👍 This is working well! I made a note of two style-issues that we may want to remedy before merging. One should be fairly simple; the other seems to be related to Redux actions sequences and I couldn't readily see why it was doing what it was doing when stepping through with redux-devtools.

[jwalgran]

Thanks for review and pointing out those two issues.
I was able to fix the button-on-same-line issue but just changing the fragment to a div. No style needed.

We paired on the flash of submit button issues and solved it by paying attention to whether data is null or an empty list.

[kellyi]

Ooof -- sorry about this but I introduced a merge conflict by merging #575