Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Require claim form facility description #679

Merged
merged 2 commits into from Jul 16, 2019

Conversation

kellyi
Copy link
Contributor

@kellyi kellyi commented Jul 16, 2019

Overview

  • adjust model & add migration to make the claim a facility form
    facility description a required field
  • update client to indicate that facility description is a required
    field on the claim a facility form
  • update test for validation function

Connects #678

Demo

Screen Shot 2019-07-16 at 11 07 12 AM

Testing Instructions

  • ./scripts/resetdb then sign in as c1 and turn on claim a facility
  • sign out then sign in to the app as c2
  • search for a facility and open the claim form
  • verify that the facility description claim form field is required in the UI and that you can save the form successfully

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@kellyi kellyi force-pushed the ki/make-facility-description-required branch from f2ab585 to 6694a8f Compare July 16, 2019 15:10
@kellyi kellyi requested a review from jwalgran July 16, 2019 15:10
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works well.

I am going to fix the conflict and merge this in the interest of expediting a release.

- adjust model & add migration to make the claim a facility form
facility description a required field
- update client to indicate that facility description is a required
field on the claim a facility form
- update test for validation function
@jwalgran jwalgran force-pushed the ki/make-facility-description-required branch from 6694a8f to 14a474c Compare July 16, 2019 22:05
Migrations 0025 and 0026 were developed in parallel and do not conflict.
@jwalgran
Copy link
Contributor

This required a merge migration because it was created in parallel with #680.

@jwalgran jwalgran merged commit d06ace5 into develop Jul 16, 2019
@kellyi kellyi deleted the ki/make-facility-description-required branch August 15, 2019 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants