This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Make small Createable/Multiselect UI refactor #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop partition/concat/map code to set up selected creatable multiselect options: it's effectively useless because the createables don't care whether the selected values are within the list of choices sent from the API - adjust conditional setup for Creatable/Select components - update product_types and production_types propTypes
kellyi
force-pushed
the
ki/small-product-types-refactor
branch
from
439e70e
to
4a56cdb
Compare
kellyi
commented
Jul 17, 2019
| map(optionsInExistingSet, mapStringToOption), | ||
| map(newlyCreatedOptionsPrime, mapStringToOption), | ||
| ); | ||
| return map(value, s => ({ value: s, label: s })); |
There was a problem hiding this comment.
The deleted bit was code I wrote that in retrospect was basically useless: the point of the Createable is that any option is valid, so there's no need to intersect with the existing choices. Since we know the structure of the choices, we can just map all the values to be that.
kellyi
commented
Jul 17, 2019
| })(); | ||
|
|
||
| const SelectComponent = isCreatable ? Creatable : Select; |
There was a problem hiding this comment.
Since these two components get an identical set of props, we can cut some lines below by conditionally choosing the component here.
jwalgran
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I had some very tiny epiphanies about simpler ways to do the multiselect/creatable dropdowns for product types & production types, so I'm making this PR to update the code before we forget about it.
multiselect options: it's effectively useless because the createables
don't care whether the selected values are within the list of choices
sent from the API
Connects #652
Testing Instructions
Checklist
fixup!commits have been squashed