This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Only pan map if facility not in viewport bbox #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyi
force-pushed
the
ki/fix-map-panning-bug
branch
from
2ed5e5a
to
42e33b5
Compare
- pan the map if the newly selected facility is not in the viewport bbox - don't pan the map if the newly selected facility is already visible in the viewport bbox
kellyi
force-pushed
the
ki/fix-map-panning-bug
branch
from
42e33b5
to
b7321cc
Compare
|
Sorry for the delay. Looking at this now. |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
the viewport bbox
Fixes #718
Testing Instructions
Checklist
fixup!commits have been squashed