This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Prevent map crash by not using strict equality when comparing point coordinates #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Points were not being combined into a disambiguation popup and throwing an exception when a precision or rounding error prevented the points from being strictly equal.
Connects #734
Testing Instructions
./scripts/resetdb
./scripts/manage dbshell
and set the same location for all facilities in VN.97
cluster. Verify that the map component does not crash and a disambiguation popup is displayed.Checklist
fixup!
commits have been squashed