This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fetch all facilities by default on main page when vector tile feature is active #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyi
force-pushed
the
ki/show-facility-tab-by-default
branch
from
b5e6dd4
to
9e2b0a7
Compare
|
Looking at this now. |
jwalgran
approved these changes
Sep 6, 2019
| @@ -95,15 +103,27 @@ class FilterSidebar extends Component { | |||
| </p> | |||
| </div>); | |||
|
|
|||
| const activeTabIndex = filterSidebarTabs | |||
| const orderedTabsForSidebar = vectorTileFeatureIsActive | |||
| ? filterSidebarTabs.slice().reverse() | |||
There was a problem hiding this comment.
Clever use of reverse here. I think that having "Guide" last makes sense.
| makeSearchTabActive, | ||
| makeFacilitiesTabActive, | ||
| ][value]; | ||
| const changeTabDictionary = vectorTileFeatureIsActive |
There was a problem hiding this comment.
Consider changeTabList to reflect the arrayness.
There was a problem hiding this comment.
Good catch -- I'll rename before merging.
When the vector tile feature is active, fetch all facilities by default on the main map and sidebar page. Also make the "Facilities" tab the initially displayed tab on loading the map page if the vector tile feature is active. Add guards to retain prior map behavior when the vector tile feature is not active.
kellyi
force-pushed
the
ki/show-facility-tab-by-default
branch
from
9e2b0a7
to
6c94a3d
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When the vector tile feature is active, fetch all facilities by default
on the main map and sidebar page. Also make the "Facilities" tab the
initially displayed tab on loading the map page if the vector tile
feature is active.
Add guards to retain prior map behavior when the vector tile feature is
not active.
Connects #765
Demo
Notes
Making this work while keeping the same functionality as before when the feature flag is off was a little tricky, but I think I came up with a good way to handle it which was to defer rendering any components that need to know the state of feature flags until the feature flags have returned from the API.
Testing Instructions
Using the standard set of fixtures, serve this branch, then...
With the
vector_tileswitch turned off, use the app and verify that it still works as it did before.With the
vector_tileswitch turned on, use the app and verify that the facilities tab populates with data as expected.In particular: clicking the "reset" button for the vector tiles version will now undertake a new search.
Checklist
fixup!commits have been squashed