Conversation
Chatted about this and it seems like we need to update the serializer to return the correct id value. We'll also need to update https://github.com/open-apparel-registry/open-apparel-registry/blob/develop/src/app/src/components/FacilityDetailSidebarClaimedInfo.jsx#L85 to match whatever changes we decide to make to the serializer and the dashboard claim details page. |
I reverted the original front-end implementation and took another look at the serializer. Turns out we were inconsistent about the parent company's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested this out by going through the steps to recreate the bug outlined in #729 and the links are now pointing to the correct contributor page!
Heads up that there's a merge conflict in the CHANGELOG file again. |
6259ac7
to
8577acb
Compare
This has another merge conflict. |
Previously we would sometimes use the parent contributor's id, and sometimes the parent contributor's admin's id. Since we use the latter to view profiles on the front-end, standardize to it in all cases.
8577acb
to
6bdad93
Compare
That should fix it. |
Thanks for taking a look, and for talking me through this. Will merge when green. |
Overview
There is no detail page for Facility Parent Company entities, as both Claim Contributors and Facility Parent Company links open the same page. In cases when the IDs of the two are not in sync, clicking the Facility Parent Company link would go to the wrong page.
By making the link always point to the Claim Contributor's id, we ensure that it is always correct.
Connects #729
Demo
Testing Instructions
c1@example.com
and go to the dashboard to view its detailsChecklist
fixup!
commits have been squashed