This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix bug which prevented marker layer from loading #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous work to encode the querystring into the tile cachekey mixed up some function arguments. In turn this prevents the vector tile facilities layer from loading. Additionally: the function extracted to create the tileURL was unconditionally requesting the facility grid layer, which would cause the markers layer to load as a grid, too. This change fixes the bug so that the marker layer will render correctly.
kellyi
force-pushed
the
ki/fix-marker-layer
branch
from
b7cbcf3
to
95ee400
Compare
rajadain
approved these changes
Sep 9, 2019
|
Cool! Thanks for catching that and reviewing this so quickly! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previous work to encode the querystring into the tile cachekey mixed up
some function arguments. In turn this prevents the vector tile
facilities layer from loading. Additionally: the function extracted to
create the tileURL was unconditionally requesting the facility grid
layer, which would cause the markers layer to load as a grid, too.
This change fixes the bug so that the marker layer will render
correctly.
Connects #762
Testing Instructions
Checklist
fixup!commits have been squashed