Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Close Disambiguation Popup on New Search #825

Merged
merged 2 commits into from Sep 24, 2019
Merged

Close Disambiguation Popup on New Search #825

merged 2 commits into from Sep 24, 2019

Conversation

rajadain
Copy link
Contributor

@rajadain rajadain commented Sep 20, 2019 •
edited by kellyi

Overview

Similar to 02bd8f3 and #812, this closes the disambiguation popup when a new search is performed. We use facilities.fetching as a proxy for telling when a new search has been fired.

Connects #796

Demo

In the old map:

2019-09-20 16 40 50

In the new map:

2019-09-20 16 44 08

Testing Instructions

  • Note if vector_tile waffle switch is on or off
  • Check out this branch and server
  • Go to the home page and search for "saitex"
  • Click through to the markers until you see a disambiguation popup
  • Switch the sidebar to search, and search for something else, without clicking Reset
    • Ensure the disambiguation popup closes
  • Toggle vector_tile and run the above test again
    • Ensure the disambiguation popup closes

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@rajadain
Close disambiguation popup on new search
4db318c 
Similar to 02bd8f3, this closes the disambiguation popup
when a new search is performed. We use facilities.fetching
as a proxy for telling when a new search has been fired.
@rajadain rajadain changed the title Close disambiguation popup on new search Close Disambiguation Popup on New Search Sep 20, 2019
kellyi
kellyi approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested this out and both the vector tile and non-vector tile cases are working as described!

@kellyi kellyi assigned rajadain and unassigned kellyi Sep 24, 2019
@rajadain rajadain merged commit a99519e into develop Sep 24, 2019
@rajadain rajadain deleted the tt/close-popup-on-reset-2 branch September 24, 2019 14:27
@rajadain
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kellyi kellyi kellyi approved these changes

Assignees

@rajadain rajadain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rajadain @kellyi