Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Update guide tab with new vector tile text #834

Merged
merged 1 commit into from Sep 30, 2019
Merged

Conversation

kellyi
Copy link
Contributor

@kellyi kellyi commented Sep 26, 2019

Overview

  • add new guide tab text to display when the vector tile feature is
    active
  • keep old text for displaying prior to activating vector tiles

Connects #829

Testing Instructions

  • verify that you see the new text when the vector tile feature is active and the old text when it's not

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@kellyi kellyi requested review from rajadain and removed request for jwalgran September 26, 2019 20:52
@kellyi kellyi assigned rajadain and unassigned jwalgran Sep 26, 2019
Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good. Some minor comments before this can be ✅

src/app/src/components/FilterSidebarGuideTab.jsx Outdated Show resolved Hide resolved
src/app/src/components/FilterSidebarGuideTab.jsx Outdated Show resolved Hide resolved
src/app/src/components/FilterSidebar.jsx Show resolved Hide resolved
@jwalgran
Copy link
Contributor

Kelly was out so I made the small fixups. This is ready for another look.

@rajadain
Copy link
Contributor

Taking another look.

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, works great. Friendly reminder to squash fixups before merging.

@rajadain rajadain assigned kellyi and unassigned rajadain Sep 30, 2019
- add new guide tab text to display when the vector tile feature is
active
- keep old text for displaying prior to activating vector tiles
@kellyi kellyi merged commit 5b82265 into develop Sep 30, 2019
@kellyi kellyi deleted the ki/update-guide-tab-copy branch September 30, 2019 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants