Conversation
2494260
to
bc116ce
Compare
This has a migration conflict. Fixing now. |
bc116ce
to
e0e2bc8
Compare
Fixed the migration conflict and rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 tested. I don't have a clear sense of the larger design change that this is serving, so can't comment on the context, but this implementation is correct.
Thank you for the review.
This is the highest level view of what this set of pulls it trying to achieve. In order to allow submission of individual facilities we are inserting #857 is where all of the major work happens. #858 is "cleanup." I will be assigning those for review shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Ran through the testing instructions and everything worked as described. I did not see any lists without sources.
Starts the process of adding support for single-item submissions by introducing a model that can connect a `FacilityListItem` to a `Contributor` without needing a `FacilityList` `FacilityListItem.source` is nullable for now to make the migration backward compatible.
This command will be used as part of the backward compatible migration process. It creates or updates `Source` objects from `FacilityList` objects and also updates the `source` foreign key on related `FacilityListItems`. It is intended that this command be removed after deployed application code is updated to create and reference `Source` objects.
e0e2bc8
to
a9d7c08
Compare
Thanks for the reviews. |
Overview
The first step of a three step process to add a Source model between facility lists and list items, allowing for the submission of individual facilities.
Each step in the process is intended to be released separately and maintain backward compatibility.
Connects #817
Testing Instructions
develop
and./scripts/resetdb
./scripts/migrate
./scripts/manage liststosources
runs without error./scripts/manage shell_plus
to verify that aSource
is created for eachFacilityList
and that aSource
is assigned on eachFacilityListItem
Checklist
fixup!
commits have been squashed