Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Check geocoded_point is not None when serializing other locations #861

Merged
merged 1 commit into from Oct 7, 2019

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Oct 7, 2019

Overview

Prevents an exception from being raised in the serializer when a list item failed geocoding but was able to be matched to another facility.

Connects #850

Testing Instructions

  • Verify that the unit tests pass

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Prevents an exception from being raised in the serializer when a list item
failed geocoding but was able to be matched to another facility.
Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Saw the tests pass on CI and also ran them & had them pass locally.

@kellyi kellyi assigned jwalgran and unassigned kellyi Oct 7, 2019
@jwalgran
Copy link
Contributor Author

jwalgran commented Oct 7, 2019

Thanks for the review.

@jwalgran jwalgran merged commit ea5972c into develop Oct 7, 2019
@jwalgran jwalgran deleted the jcw/fix-none-other-location branch October 7, 2019 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants