Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add People's Republic of China as alternate country name #876

Merged
merged 1 commit into from Oct 14, 2019

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Oct 14, 2019

Fixes parse errors when contributing lists that use this name.

Overview

Brief description of what this PR does, and why it is needed.

Connects #868

Testing Instructions

This assumes the database has been reset with ./scripts/resetdb

vagrant@vagrant:/vagrant$ ./scripts/manage batch_process --list-id 16 --action parse
Starting vagrant_database_1 ... done
parse: 1 successes
parse: 2 failures
vagrant@vagrant:/vagrant$ ./scripts/manage batch_process --list-id 17 --action parse
Starting vagrant_database_1 ... done
parse: 3 successes

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Fixes parse errors when contributing lists that use this name.
Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-10-14 at 4 49 45 PM

@kellyi kellyi assigned jwalgran and unassigned kellyi Oct 14, 2019
@jwalgran jwalgran merged commit 32d7520 into develop Oct 14, 2019
@jwalgran jwalgran deleted the jcw/add-prc branch October 14, 2019 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants