Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Allow superusers to change the Contributor of a Source #901

Merged
merged 1 commit into from Nov 4, 2019

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Nov 4, 2019

Overview

The ability to transfer the ownership of a "public list" to a contributor after they sign up was lost when we transitioned to using the Source model and made the contributor field read-only on the admin.

Connects #900

Demo

Screen Shot 2019-11-04 at 11 59 27 AM

Testing Instructions

This assumes you have run ./scripts/resetdb

  • Register a new account.
  • Log in as c1@example.com
  • Browse http://localhost:8081/admin/api/source/2/change/. Verify that the Contributor field is a dropdown list.
  • Make note of the old contributor, select a different contributor, and save the Source. Make note of the new contributor.
  • Browse http://localhost:8081/?contributors=2 and verify that there are no results.
  • Search for the newly registered contributor account and verify that there are results.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, works as described!

@rajadain rajadain assigned jwalgran and unassigned rajadain Nov 4, 2019
The ability to transfer the ownership of a "public list" to a contributor after
they sign up was lost when we transitioned to using the `Source` model and made
the `contributor` field read-only on the admin.
@jwalgran jwalgran force-pushed the jcw/admin-edit-source-contributor branch from 1c683f6 to c84447b Compare November 4, 2019 20:05
@jwalgran
Copy link
Contributor Author

jwalgran commented Nov 4, 2019

Thanks for the review.

@jwalgran jwalgran merged commit 55b001a into develop Nov 4, 2019
@jwalgran jwalgran deleted the jcw/admin-edit-source-contributor branch November 4, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants