Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Forgot password not case-sensitive #970

Merged
merged 1 commit into from Mar 3, 2020
Merged

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Mar 2, 2020

Overview

When users enter their email to retrieve a forgotten password,
the search to confirm their email is not case-sensitive.

Connects #968

Demo

email_case

Testing Instructions

  • Checkout this branch
  • Run vagrant ssh and ./scripts/server
  • Go to 'login' and select 'forgot password'
  • Enter your email with capitalization that doesn't match how you originally capitalized it when you signed up
  • The forgot password email should 'send' successfully (check the console to see it printed there)

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, simple fix. I realized while reviewing this that case sensitivity is a larger issue and created #972 to continue the work.

A reminder to work complete the PR checklist before merging this PR. Since is a a simple, 1-commit change consider squashing the README update with the functional commit.

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Mar 2, 2020
When users enter their email for to retrieve a forgotten password,
the search to confirm their email is not case-sensitive.
@TaiWilkin TaiWilkin merged commit e27b493 into develop Mar 3, 2020
@TaiWilkin TaiWilkin deleted the tw/email-case-sensitivity branch March 3, 2020 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants