Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Update parent company label #971

Merged
merged 1 commit into from Mar 5, 2020
Merged

Update parent company label #971

merged 1 commit into from Mar 5, 2020

Conversation

TaiWilkin
Copy link
Contributor

Overview

Through the "Claim a Facility" mechanism, we request information on "Parent Company" which, if available on the OAR, is listed on claimed profiles. We heard during the recent OECD conference that many facility owners or factory groups do not understand use of the language "Parent Company" as it relates to company structure. This label has been updated to "Parent Company / Supplier Group" where it appears throughout the application.

Connects #959

Demo

Screen Shot 2020-03-02 at 2 10 03 PM

Testing Instructions

  • Checkout this branch
  • Run vagrant ssh and ./scripts/server
  • Claim a facility. When you get to Step 3 in the process, 'Parent Company' should read 'Parent Company / Supplier Group'
  • Verify the facility claim through an admin account. 'Parent company' should be labeled 'Parent company / supplier group'
  • As the user who claimed the facility, look at the facility details. 'Parent Company' should read 'Parent Company / Supplier Group'

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaiWilkin TaiWilkin requested a review from jwalgran March 3, 2020 19:00
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additional changes look good, but there is a missing space that we should fix up.

src/django/api/models.py Show resolved Hide resolved
@TaiWilkin TaiWilkin requested a review from jwalgran March 4, 2020 14:26
@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Mar 5, 2020
We heard during the recent OECD conference that many facility owners or
factory groups do not understand use of the language "Parent Company"
as it relates to company structure.

This field in the OAR "Claim a Facility" process, and on the claimed
profiles, has been updated to: "Parent Company / Supplier Group".
@TaiWilkin TaiWilkin merged commit 1afbd9d into develop Mar 5, 2020
@TaiWilkin TaiWilkin deleted the tw/rename-parent-company branch March 5, 2020 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants