Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Parcel model results depend strongly on dz #765

Closed
claresinger opened this issue Feb 14, 2022 · 17 comments · Fixed by #1106 or #1225
Closed

FEATURE: Parcel model results depend strongly on dz #765

claresinger opened this issue Feb 14, 2022 · 17 comments · Fixed by #1106 or #1225
Assignees

Comments

@claresinger
Copy link
Collaborator

We changed the parcel settings to run in dz not dt (for ease when running with many different w). When we did this, we noticed unexpected behavior, where the result of the equilibrium supersaturation reached for the parcel strongly depends on the dz used even when it is very small (1 m) where we don't think the piecewise constant pressure approximation should lead to any errors.

Minimal example to produce bug on this branch: https://github.com/claresinger/PySDM-examples/tree/ss_eq_error

fig 2 from Lowe example with dz=0.1 m
fig2ab_dz=0 1
fig 2 from Lowe example with dz=1 m
fig2ab_dz=1

@slayoo slayoo changed the title BUG: Parcel model results depend strongly on dz FEATURE: Parcel model results depend strongly on dz Feb 14, 2022
@slayoo
Copy link
Member

slayoo commented Feb 14, 2022

Thank you, Clare!

@claresinger
Copy link
Collaborator Author

claresinger commented Feb 14, 2022

Maybe #746 should be a priority to implement!

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@claresinger
Copy link
Collaborator Author

fig_2ab_dz1.pdf
fig_2ab_dz001.pdf
Just confirming this issue still exists. Should we try implementing #746 to fix it?

@slayoo
Copy link
Member

slayoo commented Feb 26, 2023

@abulenok's #868 fixes a number of issues with parcel thermodynamics, likely worth checking it out first

@claresinger
Copy link
Collaborator Author

Is #868 going to be merged in soon? If not, I can check the dz sensitivity on that branch later this week.

@github-actions
Copy link

Stale issue message

@claresinger
Copy link
Collaborator Author

@slayoo @abulenok What's the status with #868 and slayoo/PySDM-examples#164 ?

@slayoo
Copy link
Member

slayoo commented Apr 29, 2023

@claresinger, we've been actually focusing on condensation in the last weeks what resulted in reporting a bug report to Numba yesterday (it is a SciPy/Numba incompatibility): numba/numba#8931 This is the reason why we intermittently get CI failures in condensation, and likely also related with the issues of condensation/parcel examples using the BDF solver taking actually almost half of the CI time (much more than 1D or 2D cases!)

BTW, if you know of any other BDF Python package that we could use instead of SciPy, this could be great to introduce (however, the key constraint is to not introduce any cumbersome dependencies).

Concerning the adaptivity criteria, I'll try to have a look again on these PRs and prepare a TODO list which could help us estimate how much effort is needed to finally switch from thd to RH as the adaptivity control base.

Thanks

@github-actions
Copy link

Stale issue message

@slayoo
Copy link
Member

slayoo commented Aug 21, 2023

@claresinger, let's reopen this one till we have this test case in place as a unit test

@github-actions
Copy link

Stale issue message

Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants