-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Parcel model results depend strongly on dz #765
Comments
Thank you, Clare! |
Maybe #746 should be a priority to implement! |
Stale issue message |
Stale issue message |
Stale issue message |
Stale issue message |
Stale issue message |
fig_2ab_dz1.pdf |
Is #868 going to be merged in soon? If not, I can check the dz sensitivity on that branch later this week. |
Stale issue message |
@slayoo @abulenok What's the status with #868 and slayoo/PySDM-examples#164 ? |
@claresinger, we've been actually focusing on condensation in the last weeks what resulted in reporting a bug report to Numba yesterday (it is a SciPy/Numba incompatibility): numba/numba#8931 This is the reason why we intermittently get CI failures in condensation, and likely also related with the issues of condensation/parcel examples using the BDF solver taking actually almost half of the CI time (much more than 1D or 2D cases!) BTW, if you know of any other BDF Python package that we could use instead of SciPy, this could be great to introduce (however, the key constraint is to not introduce any cumbersome dependencies). Concerning the adaptivity criteria, I'll try to have a look again on these PRs and prepare a TODO list which could help us estimate how much effort is needed to finally switch from Thanks |
Stale issue message |
@claresinger, let's reopen this one till we have this test case in place as a unit test |
Stale issue message |
Stale issue message |
We changed the parcel settings to run in
dz
notdt
(for ease when running with many differentw
). When we did this, we noticed unexpected behavior, where the result of the equilibrium supersaturation reached for the parcel strongly depends on thedz
used even when it is very small (1 m) where we don't think the piecewise constant pressure approximation should lead to any errors.Minimal example to produce bug on this branch: https://github.com/claresinger/PySDM-examples/tree/ss_eq_error
fig 2 from Lowe example with dz=0.1 m
![fig2ab_dz=0 1](https://user-images.githubusercontent.com/6875824/153897996-8748f605-c221-4555-8e6e-e5530b8da7be.png)
![fig2ab_dz=1](https://user-images.githubusercontent.com/6875824/153898003-bdc8ba82-a9ba-4a1a-a94a-37deddf0751e.png)
fig 2 from Lowe example with dz=1 m
The text was updated successfully, but these errors were encountered: