Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io trace reports missing device model and need units in columns #264

Closed
jcurrywa opened this issue Jul 15, 2020 · 0 comments · Fixed by #266
Closed

io trace reports missing device model and need units in columns #264

jcurrywa opened this issue Jul 15, 2020 · 0 comments · Fixed by #266
Assignees
Labels
bug Something isn't working

Comments

@jcurrywa
Copy link

  1. Both JSON and CSV reports device.model are blank
    reports for lba-histogram, latency-histogram and fs statistics are all missing the device.model
    device.id | device.model | device.name | device.size | rangeBegin | rangeEnd | read | write | discard | total
    -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    8388656 |   | sdd | 2147483648 | 1 | 1 |   | 0 |   | 0
    8388656 |   | sdd | 2147483648 | 2 | 3 |   | 0 |   | 0
    8388656 |   | sdd | 2147483648 | 4 | 7 |   | 0 |   | 0

but the Parsed IO Trace to human readable form

device.id device.model device.name device.partition file.creationDate.nanos file.creationDate.seconds file.eventType file.id file.offset file.path file.size header.sid header.timestamp io.error io.flush io.fua io.ioClass io.latency io.lba io.len io.operation io.qd io.writeHint
8388656 WDC WD4000FYYZ-0 sdd 8388656               1 123222603 FALSE FALSE FALSE 22 3264528 2210402464 256 Write 1 0
8388656 WDC WD4000FYYZ-0 sdd 8388656               2 123234707 FALSE FALSE FALSE 22 3252604 2210402720 256 Write 2 0
8388656 WDC WD4000FYYZ-0 sdd 8388656               3 123239648 FALSE FALSE FALSE 22 3247849 2210402976 256 Write 3 0
8388656 WDC WD4000FYYZ-0 sdd 8388656               4 123245725 FALSE FALSE FALSE 22 3241951 2210403232 256 Write 4 0
  1. When reporting any data in CSV, please add units where possible to improve the customer experience
    for example
    device.id | device.model | device.name | device.size (sectors) | rangeBegin (ns) | rangeEnd (ns) | read (count) | write (count) | discard | total
@mmkayPL mmkayPL self-assigned this Jul 16, 2020
@mmkayPL mmkayPL added the bug Something isn't working label Jul 16, 2020
mmkayPL added a commit to mmkayPL/standalone-linux-io-tracer that referenced this issue Jul 16, 2020
Fixes Open-CAS#264

Signed-off-by: Mateusz Kozlowski <mateusz.kozlowski@intel.com>
mariuszbarczak pushed a commit that referenced this issue Jul 17, 2020
Fixes #264

Signed-off-by: Mateusz Kozlowski <mateusz.kozlowski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants