Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh protobuf to v26.1 #1143

Open
cdeepali opened this issue May 16, 2024 · 4 comments
Open

Refresh protobuf to v26.1 #1143

cdeepali opened this issue May 16, 2024 · 4 comments
Assignees
@Aman-Surkar
Labels
enhancement New feature or request
Milestone
OpenCE 1.12

Comments

@cdeepali
Copy link
Contributor

cdeepali commented May 16, 2024 •
edited

Refresh protobuf to v26.1
@cdeepali cdeepali added the enhancement New feature or request label May 16, 2024
@cdeepali cdeepali changed the title Update protobuf to v26.1 Refresh protobuf to v26.1 May 16, 2024
@cdeepali
Copy link
Contributor Author

setup.py is removed in protobuf v26 - protocolbuffers/protobuf#15708.
The documentation suggests that PYPI source code can be used to build protobuf from source using setup.py - https://github.com/protocolbuffers/protobuf/tree/main/python#building-from-setuppy.

@cdeepali
Copy link
Contributor Author

PyPI does not provide protobuf v4.26.1, and TF yet does not support protobuf v5. Hence, decided to build protobuf v25.3.

v4.25.3 is available for both cpp and python - https://github.com/protocolbuffers/protobuf/blob/v25.3/version.json.

@cdeepali cdeepali added this to the OpenCE 1.12 milestone May 16, 2024
@Aman-Surkar
Copy link
Contributor

Aman-Surkar commented May 28, 2024 •
edited

Protobuf > 21.12 causes build failure for Pytorch, so keeping protobuf and libprotobuf as it i.e. 21.12.

@Aman-Surkar
Copy link
Contributor

Onnx 1.16.1 requires protobuf ==4.21.12: https://github.com/onnx/onnx/blob/595228d99e3977ac27cb79d5963adda262af99ad/requirements-release.txt#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman-Surkar Aman-Surkar

Labels
enhancement New feature or request
Projects
None yet
Milestone
OpenCE 1.12
Development

No branches or pull requests
2 participants
@cdeepali @Aman-Surkar