New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yarn #171
Add support for yarn #171
Conversation
Pull Request Test Coverage Report for Build 321
馃挍 - Coveralls |
Pull Request Test Coverage Report for Build 324
馃挍 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this!
I had in mind that someone would like to have yarn
support very soon when rewriting concurrently for the v4 release...
You took a good approach here.
However I feel we need to adjust something: yarn run <script> -- <args>
isn't exactly the optimal way to call a yarn script.
It yields this for me:
$ yarn test:watch -- home
yarn run v1.7.0
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
I think there should be some per-tool customisation in the command building.
The other option would be to split the implementations.
What do you think?
I may not fully understand the concern. When I look at how our tool builds commands, I don't see a scenario where we add E.g. |
Oh, sorry. You are correct. |
Published on v4.1.0! 馃殺 |
Hello 馃憢. I wasn't sure what the interest level is in this, so I just put together a PR to demonstrate it. My organization uses yarn instead of npm, and this makes
concurrently
more useful to us.This adds support for the popular npm replacement, yarn.