upgrade date-fns to v2.0.1 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
approved these changes
Sep 6, 2019
|
@gustavohenke technically yes, though it should only users of the progrematic API, and even then - only those who override the default timestamp format. |
|
Super keen on this merge - the only thing holding our code base back... |
|
@gustavohenke / @kimmobrunfeldt can this PR be merged, or is it waiting for something? It was approved almost a month ago. |
|
Hey everyone! Sorry for the delay. I was waiting for the approval to turn 1 month old 🎂 Jokes apart... you may start using this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date-fns@2has been released, and sinceconcurrentlyis pinned on^1.x.x, it makes it hard for usersconcurrentlyto usedate-fns@2simultaneously, due to conflicting packages.This PR updates this dependency.
Note that this is a breaking change in
concurrentlyfor users who may have passed an invalid format (which previously worked) due to a breaking change indate-fns@2.0.0, to better conform the unicode standard