Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

Parties are referenced check: Export list of parties/roles which aren't referenced #53

Closed
duncandewhurst opened this issue Jul 29, 2020 · 5 comments
Labels
check results Relating to the non-visualization reporting of check results compiled release checks Relating to compiled release-level check pages
Projects

Comments

@duncandewhurst
Copy link

duncandewhurst commented Jul 29, 2020

In the parties are referenced check I can see that there 69,903 parties/roles which aren't referenced, but I can't see which parties/roles have the issue, e.g. is it always the 'payer' role or are there other roles which aren't referenced.

Ideally I'd like to be able to export a results table with the following columns:

ocid, parties/id, parties/roles, unreferenced role

(Edit: typo)

@jpmckinney
Copy link
Member

Clicking on a few Previews, it seems to mostly be 'payer'. I see 'tenderer' also fails, because there are no references from tender/tenderers (though there are references from bids/details/tenderers).

We can perhaps consider an export as a tag in the reporting feature #6 @hrubyjan

@jpmckinney jpmckinney added feature Relating to more complex features and removed visualizations labels Jul 29, 2020
@duncandewhurst
Copy link
Author

Ah yes, this is similar to the requests in #6 (comment) and #6 (comment) to download a list of failures - but with more specific details on what the failure was exactly.

@jpmckinney jpmckinney added check results Relating to the non-visualization reporting of check results and removed feature Relating to more complex features labels Sep 2, 2020
@jpmckinney jpmckinney added the compiled release checks Relating to compiled release-level check pages label Mar 4, 2021
@hrubyjan hrubyjan added this to To do in pelican via automation Jul 7, 2021
@hrubyjan
Copy link

hrubyjan commented Jul 9, 2021

@duncandewhurst @jpmckinney I think we have this problem only for two checks which aggregates the data for more objects of the same type. For Parties are referenced and Period's duration is consistent with start and end dates (see #59).

I think the easiest and most logical way how to deal with this problem is to decompose the two checks into 5 (6 respectively for #59) separate checks.

Then you'll see it like you see organization reference checks or role is set checks or role's name is consistent checks
image

So we'll have procuring entitty is referenced, tenderes are referenced, suppliers are referenced etc.... and you'll nicely see which role is not referenced properly (for #59 which period is problematic)

What do you think about it?

@jpmckinney
Copy link
Member

That sounds good to me, and is consistent with the approach taken for other types of checks.

pelican automation moved this from To do to Done Jul 9, 2021
@jpmckinney jpmckinney reopened this Jul 9, 2021
pelican automation moved this from Done to In progress Jul 9, 2021
@jpmckinney jpmckinney moved this from In progress to To do in pelican Jul 9, 2021
@duncandewhurst
Copy link
Author

Sounds good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
check results Relating to the non-visualization reporting of check results compiled release checks Relating to compiled release-level check pages
Projects
No open projects
Development

No branches or pull requests

3 participants