This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Add Split Packages and output file format options #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 81-split_files
81 split files
Work of @Ravf95 from UCA. |
closes #82 |
aguilerapy
changed the title
Add Split Packages
Add Split Packages and output file format options
Jul 3, 2020
# Conflicts: # default/templates/default/compile.html # locale/es/LC_MESSAGES/django.po
romifz
suggested changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my only question is why the encoding/pretty print options are not available for other features like compile and to-json.
Also, I think we don't have a URL input option for this feature, should we use this PR to add it?
# Conflicts: # default/static/css/custom.css
Co-authored-by: Romina Fernández <romifz@gmail.com>
# Conflicts: # default/templates/default/split-packages.html
romifz
suggested changes
Jul 25, 2020
Co-authored-by: Romina Fernández <romifz@gmail.com>
# Conflicts: # default/decorators.py # default/static/js/uploader.js # default/templates/default/base-uploader.html # default/templates/default/compile.html # default/templates/default/snippets/published_date_scripts.html # default/templates/default/snippets/url_uploader_scripts.html # default/templates/default/to-json.html # default/templates/default/to-spreadsheet.html # default/templates/default/upgrade.html # default/views.py # locale/es/LC_MESSAGES/django.po
romifz
suggested changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few small suggestions, once they're addressed I think we are good to go.
Co-authored-by: Romina Fernández <romifz@gmail.com>
…nto 81-split_files
romifz
approved these changes
Sep 4, 2020
# Conflicts: # default/templates/default/to-spreadsheet.html # default/views.py # locale/es/LC_MESSAGES/django.po
romifz
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #81