Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Add Split Packages and output file format options #104

Merged
merged 45 commits into from
Sep 8, 2020
Merged

Conversation

aguilerapy
Copy link
Contributor

closes #81

@aguilerapy aguilerapy changed the title Add Split Package Add Split Packages Jul 3, 2020
@aguilerapy
Copy link
Contributor Author

Work of @Ravf95 from UCA.

@aguilerapy
Copy link
Contributor Author

closes #82

@aguilerapy aguilerapy changed the title Add Split Packages Add Split Packages and output file format options Jul 3, 2020
# Conflicts:
#	default/templates/default/compile.html
#	locale/es/LC_MESSAGES/django.po
@aguilerapy aguilerapy requested a review from romifz July 6, 2020 23:12
Copy link
Contributor

@romifz romifz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only question is why the encoding/pretty print options are not available for other features like compile and to-json.

Also, I think we don't have a URL input option for this feature, should we use this PR to add it?

default/decorators.py Outdated Show resolved Hide resolved
default/decorators.py Outdated Show resolved Hide resolved
default/static/js/uploader.js Outdated Show resolved Hide resolved
default/templates/default/snippets/optional_arguments.html Outdated Show resolved Hide resolved
default/templates/default/split-packages.html Outdated Show resolved Hide resolved
default/templates/default/split-packages.html Outdated Show resolved Hide resolved
locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@aguilerapy aguilerapy requested a review from romifz July 24, 2020 00:15
default/static/js/uploader.js Outdated Show resolved Hide resolved
default/static/js/uploader.js Outdated Show resolved Hide resolved
aguilerapy and others added 2 commits July 27, 2020 11:52
Co-authored-by: Romina Fernández <romifz@gmail.com>
@aguilerapy aguilerapy requested a review from romifz August 7, 2020 19:34
# Conflicts:
#	default/decorators.py
#	default/static/js/uploader.js
#	default/templates/default/base-uploader.html
#	default/templates/default/compile.html
#	default/templates/default/snippets/published_date_scripts.html
#	default/templates/default/snippets/url_uploader_scripts.html
#	default/templates/default/to-json.html
#	default/templates/default/to-spreadsheet.html
#	default/templates/default/upgrade.html
#	default/views.py
#	locale/es/LC_MESSAGES/django.po
Copy link
Contributor

@romifz romifz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few small suggestions, once they're addressed I think we are good to go.

default/static/js/uploader.js Outdated Show resolved Hide resolved
default/static/js/uploader.js Outdated Show resolved Hide resolved
default/static/js/url_uploader.js Outdated Show resolved Hide resolved
locale/es/LC_MESSAGES/django.po Show resolved Hide resolved
# Conflicts:
#	default/templates/default/to-spreadsheet.html
#	default/views.py
#	locale/es/LC_MESSAGES/django.po
@romifz romifz merged commit 2fa3d53 into master Sep 8, 2020
@romifz romifz deleted the 81-split_files branch September 8, 2020 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a functionality to split files into smaller files
3 participants