Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PduHeader has invalid length and status attributes #3

Closed
delaneyj opened this issue May 1, 2019 · 3 comments
Closed

PduHeader has invalid length and status attributes #3

delaneyj opened this issue May 1, 2019 · 3 comments

Comments

@delaneyj
Copy link
Contributor

delaneyj commented May 1, 2019

Per the 1278.1-2012 spec for PduHeader

Length. This field shall specify the length of the PDU, including the PDU Header, in octets and shall be represented by a 16-bit unsigned integer....
PDU Status...This record shall be defined as an 8-bit record....

The spec goes into further details on the fields. However the DIS7.xml and all generated code has incorrect sizing of these fields. Given this is the basis for all PDUs how do any of the generated implementations correctly generate or read any messages streams correctly?

@leif81
Copy link
Member

leif81 commented May 15, 2019

Thank you for the report @delaneyj

To be honest, I only use the DIS6 implementation (the Java and C++ ones), so I don't have experience using the DIS7 implementation to confirm your observation.

If you have some sample DIS7 PDU's what you could do is submit a pull request with a unit test in the open-dis-java project to confirm it fails to parse them.

@kurtsansom
Copy link

kurtsansom commented Jan 19, 2021

This appears to be resolved?
PduHeader is not used, Pdu inherits PduSuplerClass

@delaneyj
Copy link
Contributor Author

Not that I'm aware of, I instead built a Go lib by head directly from the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants