Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionRequestPdu duplicate handling of entity ids #146

Closed
phutson opened this issue Apr 18, 2024 · 2 comments · Fixed by #149
Closed

ActionRequestPdu duplicate handling of entity ids #146

phutson opened this issue Apr 18, 2024 · 2 comments · Fixed by #149
Labels
bug

Comments

@phutson
Copy link

phutson commented Apr 18, 2024 •
edited
Loading

In ActionRequestPdu, it unmarshals the two entity IDs that are already unmarshaled and marshaled in the superclass. The unmarshaling and marshaling of originating id and receiving id should be removed from the ActionRequestPdu.
@leif81
Copy link
Member

leif81 commented Apr 18, 2024

Thanks for the report @phutson

Are you interested and able to submit a pull request for the proposed change ?

@leif81 leif81 added the bug label Apr 18, 2024
@phutson
Copy link
Author

phutson commented Apr 18, 2024

Yes I can add a pull request.

This was linked to pull requests Apr 18, 2024
Removing shadowed entity ids and duplicate actions on them #148
Closed
Issue 146 #149
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@leif81 @phutson